----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/#review70361 -----------------------------------------------------------
if you want, but the sentence sounds like KRun only reads from that config file, while it also writes into it. This is why I consider it an implementation detail... the app doesnt need to care about it, right? - David Faure On nov. 1, 2014, 10:31 matin, Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120926/ > ----------------------------------------------------------- > > (Updated nov. 1, 2014, 10:31 matin) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Since `setShowScriptExecutionPrompt()` is used to specify whether a prompt > should be shown or not, we don't neither need to check it again nor do we > need to call `setRunExecutable()` inside KIO. The caller is anyway forced to > do something like: > > if (value == "alwaysAsk") { > run->setShowScriptExecutionPrompt(true); > } else { > run->setRunExecutables(value == "execute"); > } > > > Diffs > ----- > > src/widgets/krun.h cd5bcaa > > Diff: https://git.reviewboard.kde.org/r/120926/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
