> On nov. 11, 2014, 2:39 après-midi, Albert Astals Cid wrote: > > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving > > differently depending if a third party misterious compononent that is not > > documented anywhere is installed or not. If you have a dependency, well put > > it in a tier with direct access to that dependency, or put a huge warning > > in the docu saying this will lose the functionality if something else is > > not there. > > Daniel Vrátil wrote: > This requirement is documented in ktexttohtml.h in /r/121094. > > /** > * Replace text emoticons smileys by emoticons images. > * > * @note > * This option works only when FrameworkIntegration plugin is > installed, > * and requires QGuiApplication. This will not work with > QCoreApplication. > * If the FrameworkIntegration plugin is not available, or this is > called > * from a QCoreApplication, this option will not do anything. > */ > ReplaceSmileys = 1 << 2, > > The behaviour change in case the conditions above are not fulfiled are > not drastical - the flag will simply be ignored. I don't see much difference > over MessageBox not remembering "Don't show this again" between sessions, > because it would be using only memory storage when FrameworkIntegrationPlugin > is not installed (which btw is not documented at all) > > Albert Astals Cid wrote: > Why is the plugin in FrameworkIntegration and not in KEmoticons? > > Daniel Vrátil wrote: > Theoretically it could be in KEmoticons as some sort of plugin, but the > original idea was to simply follow the same path as KMessageBox to create a > runtime frameworks integration (for which "FrameworkIntegrationPlugin" seems > to be exactly the right place). > > Albert Astals Cid wrote: > But what's the point? now if i want to provide that feature i need to > pull a bazillion of dependencies instead of just KEmoticons. KMessageBox > don't show again is actually an integration feature, is this feature one? > > Aleix Pol Gonzalez wrote: > I guess what Albert means is why you aren't moving the class to > kemoticons altogether... > > Albert Astals Cid wrote: > No, i understand this class has value without ";) to image" support, i > just don't understand why the emoticons support for this class is hidden in > frameworksintegration. As another option, instead of a runtime plugin could > it be a class that inherits from it? So if i want emoticon support use > KTextToHTMLWithEmoticons and otherwie just use KTextToHTML?
I agree that the plugin should be in KEmoticons, since that depends on kcoreaddons. The KMessageBox case is different because kconfig and kwidgetaddons don't depend on each other. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/#review70238 ----------------------------------------------------------- On nov. 11, 2014, 2:51 après-midi, Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121095/ > ----------------------------------------------------------- > > (Updated nov. 11, 2014, 2:51 après-midi) > > > Review request for KDE Frameworks, David Faure and Michael Pyne. > > > Repository: frameworkintegration > > > Description > ------- > > This patch is related to /r/121094, which moves KTextToHTML conversion > utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on > KEmoticons needed for smileys conversion, I added the actual KEmoticons code > here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig > dependency for KMessageBox. > > This patch refactors the FrameworkIntegrationPlugin a bit - I split the > KMessageBox-specific code into a separate file, and added a new file with the > KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking > more and more classes into a single file :-) > > > Diffs > ----- > > CMakeLists.txt 3721bfa > src/integrationplugin/CMakeLists.txt 3395368 > src/integrationplugin/frameworkintegrationplugin.h 6dc6825 > src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d > src/integrationplugin/kmessagebox.h PRE-CREATION > src/integrationplugin/kmessagebox.cpp PRE-CREATION > src/integrationplugin/ktexttohtml.h PRE-CREATION > src/integrationplugin/ktexttohtml.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121095/diff/ > > > Testing > ------- > > Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems > to work. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
