----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ -----------------------------------------------------------
(Updated Nov. 6, 2014, 11:36 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: knotifications Description ------- ...to allow custom KNotification plugins. This class is being exported since ever, but the public header was missing. Also, I'd like to rename this class to KNotificationPlugin rather than KNotifyPlugin as there is no KNotify anymore, but renaming already exported class is not allowed in frameworks as that would break BC, right? Diffs ----- src/knotificationplugin.cpp PRE-CREATION src/knotifyplugin.h 248a66f src/knotifyplugin.cpp e2efab9 src/notifybyaudio.h 767f1ce src/notifybyaudio.cpp 99b8027 src/notifybyexecute.h 92781ef src/notifybyexecute.cpp 254341a src/notifybyktts.h a05eebf src/notifybyktts.cpp 71f9ae5 src/notifybylogfile.h 32a8ae5 src/notifybylogfile.cpp fa0c103 src/notifybypopup.h 36aac1d src/notifybypopup.cpp c7add40 src/notifybysound.h 44f6463 src/notifybysound.cpp f005b99 src/notifybytaskbar.h 83d46ce src/notifybytaskbar.cpp 173bbb8 src/CMakeLists.txt 5b109c8 src/knotification.h 456e84b src/knotificationmanager.cpp f44c660 src/knotificationmanager_p.h 19bb823 src/knotificationplugin.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120728/diff/ Testing ------- Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
