-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120902/
-----------------------------------------------------------
Review request for KDE Frameworks.
Bugs: 339863
https://bugs.kde.org/show_bug.cgi?id=339863
Repository: kwidgetsaddons
Description
-------
The old code converted the yellow star icon to grayscale for the unrated part.
With icon themes that have no color, this means the rating cannot be read,
because all stars look identical.
This code adds support for a "rating-unrated" icon that theme creators can use
for the unrated part. If the icon theme does not support this icon, it falls
back to desaturating.
Diffs
-----
src/kratingpainter.cpp 8e8a6a3
Diff: https://git.reviewboard.kde.org/r/120902/diff/
Testing
-------
I couldn't actually test with breeze theme (Qt issue?), but I locally added a
dedicated "rating-unrated.png" file to oxygen and tested both cases (present
and not).
Thanks,
Christoph Feck
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
