----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120640/#review68670 -----------------------------------------------------------
Looks good to me. +1 - Aleix Pol Gonzalez On Oct. 18, 2014, 3:47 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120640/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 3:47 a.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > Turn virtuals into Q_DECL_OVERRIDE since it's what they really are. > > Also remove putChar that tried to be an override but putChar is not virtual > anymore in QIODevice and thus we don't need to reimplement it to say it's > unsuported > > > Diffs > ----- > > src/kcompressiondevice.h 39a3206 > src/kgzipfilter.h d74ef8a > src/klimitediodevice_p.h dbc1ebf > src/knonefilter.h 9314ea2 > src/kxzfilter.h 59f00f6 > src/karchivedirectory.h 60225d0 > src/karchivefile.h c7d2e0e > src/kbzip2filter.h 72e9756 > > Diff: https://git.reviewboard.kde.org/r/120640/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
