----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/#review68284 -----------------------------------------------------------
Ship it! Looks good! Sorry, I missed this one earlier. - David Faure On Sept. 14, 2014, 2:06 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120199/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2014, 2:06 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Implement KPluginTrader::query() using KPluginLoader::findPlugins() > > > Diffs > ----- > > src/plugin/kplugintrader.cpp 024d74ca5341a2960161b55e4efde956e80f7c76 > > Diff: https://git.reviewboard.kde.org/r/120199/diff/ > > > Testing > ------- > > Unit test still passes after applying RR 120198, not sure if it works without > it. > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
