> On Oct. 10, 2014, 9:12 p.m., David Faure wrote: > > right, it's inconsistent - but I wonder, how did this create a problem for > > you? i.e. did you miss the strigi-dependent code? I thought nothing used > > that anymore, and afaik strigi for qt5 doesn't exist? > > Hrvoje Senjan wrote: > i wanted to check whether a feature was not working due to KIO_NO_STRIGI, > when i noticed that this codepath is never triggered. i actually can't > remember now what i wanted to check ;-) > only libstreams and libstreamanalyzer are used, which don't use Qt (IIRC > only thing that uses it is strigi's GUI search client). > > maybe it would be better to remove all non-triggered paths, than to > return a deprecated feature?
I checked, and strigi hasn't been ported to Qt5. You can remove all dead code paths (via reviewboard ;). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review68234 ----------------------------------------------------------- On Sept. 27, 2014, 6:19 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120393/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 6:19 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > ------- > > this has been removed in commit c8f4c69650c71276b2a2263212addde63764e58b, but > message seems unrelated to strigi check removal. > > > Diffs > ----- > > CMakeLists.txt a26fef7 > src/CMakeLists.txt 4a1d80d > > Diff: https://git.reviewboard.kde.org/r/120393/diff/ > > > Testing > ------- > > does what's expected.. alternatevily IMHO allo "! KIO_NO_STRIGI" checks > should be removed from sources ( i can take care of it, if that would be > decided) > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
