----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120479/#review67863 -----------------------------------------------------------
Ship it! Thanks for the new template. The patch looks good to me, only a few small issues :) templates/C++/kde-frameworks5/icons/CMakeLists.txt <https://git.reviewboard.kde.org/r/120479/#comment47291> As bshah said, ecm_install_icons has some new required parameters: In the end it looks like ecm_install_icons(ICONS ${var_with_icons} DESTINATION ${ICON_INSTALL_DIR} THEME hicolor) templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp <https://git.reviewboard.kde.org/r/120479/#comment47292> Clang is complaining about the same variable and class name (Build error) templates/C++/kde-frameworks5/src/main.cpp <https://git.reviewboard.kde.org/r/120479/#comment47293> There is a missing KAboutData::setApplicationData(aboutData);. That means, the about dialog will not show the application/author information (Help --> About Simple App) - Simon Wächter On Oct. 3, 2014, 4:27 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120479/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 4:27 p.m.) > > > Review request for KDE Frameworks and Simon Wächter. > > > Repository: kapptemplate > > > Description > ------- > > Port KDE 4 template to KDE Frameworks > also fix docs compile > > sample generated app: http://starsky.19inch.net/~jr/tmp/jonathan.tar.gz > > > Diffs > ----- > > CMakeLists.txt 02df39d6cc0065d1ea95cf236cf4089a40ad6299 > templates/C++/kde-frameworks5/kde-frameworks5.png PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}.desktop PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}.h PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}ViewBase.ui PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}ui.rc PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}view.h PRE-CREATION > templates/C++/kde-frameworks5/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5/COPYING PRE-CREATION > templates/C++/kde-frameworks5/COPYING.DOC PRE-CREATION > templates/C++/kde-frameworks5/Messages.sh PRE-CREATION > templates/C++/kde-frameworks5/README PRE-CREATION > templates/C++/kde-frameworks5/doc/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5/doc/index.docbook PRE-CREATION > templates/C++/kde-frameworks5/icons/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5/icons/hi16-apps-%{APPNAMELC}.png PRE-CREATION > templates/C++/kde-frameworks5/icons/hi22-apps-%{APPNAMELC}.png PRE-CREATION > templates/C++/kde-frameworks5/icons/hi32-apps-%{APPNAMELC}.png PRE-CREATION > templates/C++/kde-frameworks5/icons/hi48-apps-%{APPNAMELC}.png PRE-CREATION > templates/C++/kde-frameworks5/icons/hisc-apps-%{APPNAMELC}.svgz > PRE-CREATION > templates/C++/kde-frameworks5/kde-frameworks5.kdevtemplate PRE-CREATION > doc/index.docbook b3edf623aeac322e4775028a5d7502d80dff7327 > templates/C++/CMakeLists.txt 6f31aa3cc7a68748c82965b525c0f7eb7b956652 > templates/C++/kde-frameworks5/src/settingsBase.ui PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAMELC}view.cpp PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfg PRE-CREATION > templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfgc PRE-CREATION > templates/C++/kde-frameworks5/src/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5/src/main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120479/diff/ > > > Testing > ------- > > run kapp template, exported, compiled and installed a sample app > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
