----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120422/#review67769 -----------------------------------------------------------
src/platformtheme/kdeplatformsystemtrayicon.cpp <https://git.reviewboard.kde.org/r/120422/#comment47199> Remove src/platformtheme/kdeplatformsystemtrayicon.cpp <https://git.reviewboard.kde.org/r/120422/#comment47198> Use Q_UNUSED better because this is going to get call many times from QMenu and on all of them, it is not really a warning. Also, add a comment saying that we don't do anything with the size of the icon. - Àlex Fiestas On set. 29, 2014, 1:32 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120422/ > ----------------------------------------------------------- > > (Updated set. 29, 2014, 1:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > Otherwise it's a pure virtual class. I'm unsure what should be done in this > case though. If somebody knows I'll be happy to fix it. > > > Diffs > ----- > > src/platformtheme/kdeplatformsystemtrayicon.h 6ceaa43 > src/platformtheme/kdeplatformsystemtrayicon.cpp 3ada7d2 > > Diff: https://git.reviewboard.kde.org/r/120422/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
