----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/#review67755 -----------------------------------------------------------
Ship it! Sounds like a great idea to me. Apart from the small comments below, what's missing is also documentation, can you add a note in the api docs for setXMLFile? About your question: I'm pretty sure it's fine to put all xmlgui.rc files under the same prefix, multiple resources can populate the same directory - as long as the filenames don't clash of course. src/kxmlguiclient.cpp <https://git.reviewboard.kde.org/r/120099/#comment47192> trailing whitespace (here and further down) src/kxmlguiclient.cpp <https://git.reviewboard.kde.org/r/120099/#comment47193> no space before ( src/kxmlguifactory.cpp <https://git.reviewboard.kde.org/r/120099/#comment47194> you should configure your text editor to strip trailing whitespace on saving :-) - David Faure On Sept. 8, 2014, 10:35 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120099/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 10:35 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kxmlgui > > > Description > ------- > > Instead of installing them in the kxmlgui5 share prefix, install them in a > kxmlgui5 prefix in resources. > That will allow to test stuff without installing it first, as the resources > will be found anyway. > Still the "I can edit it and have a copy in my writable datadir" should work. > Question is: is it possible with one "kxmlgui" prefix for the resource or is > it better to swap that around like "componentname/kxmlgui5/.."? > > > Diffs > ----- > > src/kxmlguiclient.cpp e8170ad > src/kxmlguifactory.cpp c4ad97b > > Diff: https://git.reviewboard.kde.org/r/120099/diff/ > > > Testing > ------- > > Compiles & if I package ui file in kate into resource, works. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
