----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120324/#review67245 -----------------------------------------------------------
Re-reading the code and the comments, the core of the problem is described later, in another part which should be touched by the patch. The comment says: # WARNING: this has severe limitations on the windows platform since the .xsl # & docbook files need to be relocatable. We cannot just replace the paths in # the .xsl with relative paths because these files are not installed while # building kdoctools. Instead, we will reconfigure those files at install time # with relative paths. So is the limitation due to the fact that file(RELATIVE_PATH can't compute in advance the relative path with non-existing files as argument? - Luigi Toscano On Set. 23, 2014, 12:44 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120324/ > ----------------------------------------------------------- > > (Updated Set. 23, 2014, 12:44 a.m.) > > > Review request for Build System, KDE Frameworks and kdewin. > > > Repository: kdoctools > > > Description > ------- > > Unify most of the CMake code which generates the DTD instead of duplicating > the functionalities for WIN32 and non-WIN32 execution. The WIN32 branch only > needs to compute the relative path, the rest of the code can be shared. > > If accepted, a similar patch can be applied to kdelibs4support. > > > Diffs > ----- > > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120324/diff/ > > > Testing > ------- > > Tested on a Linux-based based system only, needs input from Windows > developers. > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
