> On Set. 18, 2014, 9:08 p.m., Christoph Feck wrote: > > Wait? I was _really_ expecting the .hidden file to support patterns. If the > > current specification does not allow it, what is the actual use case then? > > Wouldn't it make sense to discuss adding patterns? > > > > Directory reading is already unbelievable slow due to several levels of > > abstraction, caching, and sorting, and checking if an entry contains a * or > > ? character before matching should be worth considering the usefulness. > > Additionally, that needs only be done if the .hidden file is present at all. > > > > I cannot see how anyone would _not_ try this feature with *~ or *.bak or > > *.o entries there, and reporting a bug that "it didn't work".
The point of the *.hidden* file is to allow the user to hide a file/folder from the file manager without renaming it (prefixing a dot). Sometimes, renaming is not even possible. Being able to use patterns would be great, but I don't know how big would the additional overhead be. Probably not that much. And like you say, if there's no *.hidden* file, there's no additional overhead. But then, if implemented, the KDE "specification" of *.hidden* files would be different from the others. Even if it is decided to implement patterns, I think it should be done on a different patch and commit, so that, in case of errors or performance issues, it can be reverted easily. - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review66872 ----------------------------------------------------------- On Set. 18, 2014, 10:06 a.m., Bruno Nova wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119607/ > ----------------------------------------------------------- > > (Updated Set. 18, 2014, 10:06 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 64740 and 246260 > https://bugs.kde.org/show_bug.cgi?id=64740 > https://bugs.kde.org/show_bug.cgi?id=246260 > > > Repository: kio > > > Description > ------- > > This adds support for *.hidden* files to KDE. > > When listing a directory, the files/folders listed in the *.hidden* file will > be hidden, unless the user has chosen to show hidden files. > > This patch was initially based on the patch provided by Mark in Bug #246260. > > > Diffs > ----- > > src/core/kcoredirlister.h e6ba2ac > src/core/kcoredirlister.cpp a31d629 > src/core/kfileitem.h bebc241 > src/core/kfileitem.cpp 74dc069 > > Diff: https://git.reviewboard.kde.org/r/119607/diff/ > > > Testing > ------- > > Built and tested the patch in Project Neon. > Dolphin was still using KDE4/Qt4 version of the library, so I only tested > using the desktop folder widget, and "folder desktop". > It worked correctly when I pointed it to "~" and "~/Desktop" (I added > ".hidden" there). > However, it didn't work when I pointed it to the "Desktop folder" (the > default option, not the custom location "~/Desktop"). > More testing is required. > > The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu > 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder > widget and detailed/tree view in Dolphin). > It wasn't an intensive test, though. > > > Thanks, > > Bruno Nova > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
