----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: knotifications Description ------- Remove fallback QSystemTray support Currently when we make a StatusNotifierItem if it fails we try to create a classic X system tray icon via Qt's QSystemTray. QSystemTray now (5.4) has a QPT backend that uses KStatusNotifierItem. This means it's possible to infinite loop. This patch removes the legacy QSystemTray support to avoid that happening. Downside: it means if a frameworks app is run on a platform without statusnotifier support but still has legacy X system tray support we would now gets no icons, but that would break on Wayland anyway. Diffs ----- src/kstatusnotifieritem.h 7da1451 src/kstatusnotifieritem.cpp 767537d src/kstatusnotifieritemprivate_p.h 051cc38 Diff: https://git.reviewboard.kde.org/r/120243/diff/ Testing ------- Ran statusnotifiertest (the one in plasma-workspace) with plasma running. Everything is fine. Ran without plasma running and nothing happened (without kded5 infinite looping) Thanks, David Edmundson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
