> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ > > Maarten De Meyer wrote: > I think we'll need both. We still need to rename the kdesu binary, no?
if it goes in libexec yes, otherwise if it goes in libexec/kf5 shouldn't be necessary - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 ----------------------------------------------------------- On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120185/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2014, 3:59 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 338755 > https://bugs.kde.org/show_bug.cgi?id=338755 > > > Repository: kio > > > Description > ------- > > kdesu is installed in libexec/ look for it there first. I left the > findExecutable search as a backup. > Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be > installed in libexec/kf5? > > Insert 'kdesu' at the end to show a nicer error. If we leave this part out > the error is "Could not launch 'root'" which is somewhat correct but not as > easy to figure out as "Could not launch 'kdesu'" > > Also added an unrelated QFile::decodeName() call. > > > Diffs > ----- > > src/core/config-kiocore.h.cmake 3c2e4a8 > src/core/desktopexecparser.cpp 9510697 > > Diff: https://git.reviewboard.kde.org/r/120185/diff/ > > > Testing > ------- > > Created .desktop file with X-KDE-SubstituteUID=true > Now I can launch it as root and when I remove kdesu I got a normal error > message. > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
