----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120200/#review66473 -----------------------------------------------------------
Ship it! Ouch, nice catch! - Milian Wolff On Sept. 14, 2014, 2:37 p.m., Volker Krause wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120200/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2014, 2:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: threadweaver > > > Description > ------- > > Being declared with file-local linkage in a header file we ended up with > six instances, one per file that includes job_p.h. > > > Diffs > ----- > > src/job_p.h 937e9d40d72ea88094a412943a1291fa1c290f0e > src/job_p.cpp 4bfc7d6db278a223774f4fd849468868b2eafa6c > > Diff: https://git.reviewboard.kde.org/r/120200/diff/ > > > Testing > ------- > > > Thanks, > > Volker Krause > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel