> On Sept. 5, 2014, 10:14 p.m., David Faure wrote: > > Ship It! > > David Faure wrote: > I reworked this code today, to fix other issues (fromUserInput is wrong > for relative paths, which affected at least other parts of the code). Can you > check that it's still working for you? Thanks. > > Maarten De Meyer wrote: > Sorry about that, I'm still getting used to the QUrl api. > Local file paths still work. > Remote paths have to be given explicitly. ex 'http://www.google.com' > instead of 'www.google.com' before. Which is the expected behavior if I'm not > mistaken. > Thank you for looking into this.
Thanks for the re-test. Yes this is the expected behavior (e.g. if you want to save a file as "foo.pl" you don't expect to end up on http://foo.pl) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/#review65867 ----------------------------------------------------------- On Sept. 6, 2014, 1:44 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120071/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2014, 1:44 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 337557 > https://bugs.kde.org/show_bug.cgi?id=337557 > > > Repository: kio > > > Description > ------- > > KUrl porting error. KFileDialog cannot open url from user input because it > has no scheme. > > > Diffs > ----- > > src/filewidgets/kfilewidget.cpp 10c6120 > > Diff: https://git.reviewboard.kde.org/r/120071/diff/ > > > Testing > ------- > > Now I can open absolute url's with KFileDialog > Local and remote files work. > > Not tested: KDEPlatformFileDialog > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
