----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65866 -----------------------------------------------------------
Ah wait, I do: lots of @since 5.2 missing in api docs. And a [ChangeLog] entry like in Qt in the commit log, although I haven't written/stolen the script to extract that yet. - David Faure On Aug. 28, 2014, 7:50 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119970/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 7:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > - Add KPluginInfo::toKPluginMetaData and a unit test for it > - Add KPluginInfo::fromKPluginMetaData and add a unit test for it > - KPluginInfo: convert all meta data, not just the well known properties > - Add functions to convert between lists of KPluginMetaData and KPluginInfo > > This needs https://git.reviewboard.kde.org/r/119936 > > > Diffs > ----- > > autotests/kplugininfotest.cpp PRE-CREATION > src/services/kplugininfo.h 9a9eceee5c90c6a5516c3b03473ff6437e9b2fe4 > src/services/kplugininfo.cpp 6fadf46c902455e7f5c9ece5b34fb1e40d0a97f7 > > Diff: https://git.reviewboard.kde.org/r/119970/diff/ > > > Testing > ------- > > Unit test passes, used successfully for loading KDevelop plugins with > KPluginLoader::findPlugins() > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
