> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > <https://git.reviewboard.kde.org/r/119901/diff/6/?file=307834#file307834line2> > > > > CMake macros/functions that take a variable name usually take it first. > > Swapping the argument order would make it more consistent with other things. > > Rohan Garg wrote: > That's what I've done here? the variable being queried from qmake is > passed as the first argument and the result is stored in the second argument?
Ah, I wasn't clear enough. The *CMake* variable should be first, and the QMake one second. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65382 ----------------------------------------------------------- On Aug. 27, 2014, 1:11 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119901/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 1:11 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Use qmake to query dirs for plugins and imports instead of hardcoding them in > ECM. > > > Diffs > ----- > > modules/ECMQueryQmake.cmake PRE-CREATION > kde-modules/KDEInstallDirs.cmake 880539b > modules/ECMGeneratePriFile.cmake 34001d6 > > Diff: https://git.reviewboard.kde.org/r/119901/diff/ > > > Testing > ------- > > Seems to work on my system. > > > Thanks, > > Rohan Garg > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
