----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/#review65028 -----------------------------------------------------------
src/kstyle/kstyle.cpp <https://git.reviewboard.kde.org/r/119867/#comment45452> You do not need to use "{ }" around the case code, because it does not create a local variable. src/kstyle/kstyle.cpp <https://git.reviewboard.kde.org/r/119867/#comment45450> We use "if () {" with braces, even for single line statements. - Christoph Feck On Aug. 22, 2014, 9:23 a.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119867/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 9:23 a.m.) > > > Review request for KDE Frameworks and Àlex Fiestas. > > > Repository: frameworkintegration > > > Description > ------- > > This patch re-adds some piece of code that what thrown away when stripping > kstyle from KDE4. > It is necessary to have the CustomStyleElement etc. working. > > > Diffs > ----- > > src/kstyle/kstyle.cpp 2ff1031 > > Diff: https://git.reviewboard.kde.org/r/119867/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
