----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119767/#review64497 -----------------------------------------------------------
src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45056> Better than ^\s* is to use the attribute firstNonSpace="true", i.e.: <RegExpr attribute="Logic" context="Logic" firstNonSpace="true" String="\$"/> And as such, you can switch to <DetectChar attribute="Logic" context="Logic" firstNonSpace="true" char="$"/> src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45057> Is the beginRegion="element" somewhere missing to match this endRegion="element" ? src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45052> ^ means you match only at the beginning of the line. Faster is adding a column="0". src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45051> Are you looking for words only here? If so, you may want to use WordDetect instead of RegExr, see (search for WordDetect): http://docs.kde.org/stable/en/applications/kate/kate-highlight-rules-detailled.html src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45054> Use WordDetect instead of RegExpr. src/syntax/data/hamlet.xml <https://git.reviewboard.kde.org/r/119767/#comment45053> Use WordDetect instead of RegExpr src/syntax/data/haskell.xml <https://git.reviewboard.kde.org/r/119767/#comment45059> Increase the version to 2.3. src/syntax/data/haskell.xml <https://git.reviewboard.kde.org/r/119767/#comment45058> This rule switches to the context "List or QuasiQuote" on '['. The rules in the context "List or QuasiQuote" again switch to other contexts. Question: Do you ever #pop back to the context "code"? Would it also be possible to use fallthrough and fallthroughContext like this: <context attribute="Normal" lineEndContext="#stay" name="List or QuasiQuote" fallthrough="true" fallthroughContext="#pop"> and then remove the line 360? <IncludeRules context="code" /> Hi, nice. Could you please send a revised version with the issues addressed? - Dominik Haumann On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119767/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 4:33 p.m.) > > > Review request for Kate, KDE Frameworks and Christoph Cullmann. > > > Repository: ktexteditor > > > Description > ------- > > This request request mostly contains syntax highlighting for Hamlet > files. Hamlet is a Haskell based Template language for creating > HTML documents. As Hamlet can be embedded into an ordinary Haskell > file with quasi quotation, this also implements QuasiQuotation support > for Haskell files. > > > Diffs > ----- > > src/syntax/data/hamlet.xml PRE-CREATION > src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 > > Diff: https://git.reviewboard.kde.org/r/119767/diff/ > > > Testing > ------- > > > Thanks, > > Bastian Holst > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
