----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119745/#review64405 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 12, 2014, 8:12 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119745/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 8:12 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > These classes are exposed only as QML so we should only show members the > user can actually use. > > The invokable is moved to the top so we only need one block to hide things. > > It's not great having to add tags manually, but it's the best I've found; > especially as we can't just hide member variables as we need Q_INVOKABLES. If > this gets approved I'll do the other plasma docs. > > > Diffs > ----- > > src/declarativeimports/core/framesvgitem.h 117d10c > > Diff: https://git.reviewboard.kde.org/r/119745/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Generated Output > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/c28277e8-bdd7-4cca-aafb-e36679369dd7__api.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel