----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review63939 -----------------------------------------------------------
src/netwm.cpp <https://git.reviewboard.kde.org/r/119267/#comment44607> I assume this should be "delete [] p->activities;"? src/netwm.cpp <https://git.reviewboard.kde.org/r/119267/#comment44606> -> qstrdup? (also "new code" issue) src/netwm.cpp <https://git.reviewboard.kde.org/r/119267/#comment44605> C style cast. While i personally don't mind that at all (and it's used in the file anyway) there are objections against it and Martin might disapprove adding more. Like that much better, thanks =) Two of tehm comments are more to trigger a comment from Martin, but the "issue" one is I believe a copy 'n paste bug. - Thomas Lübking On Aug. 5, 2014, 8:21 nachm., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119267/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 8:21 nachm.) > > > Review request for KDE Frameworks, kwin and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > Currently, the library only has the method for retrieving a list of > activities a window belongs to. > > This is adding a method which provides changing the list of activities for a > window. > > > Diffs > ----- > > autotests/kwindowinfox11test.cpp 50ce806 > src/kwindowinfo_x11.cpp 041dfd3 > src/kwindowsystem.h 0b58e71 > src/kwindowsystem.cpp fb59603 > src/kwindowsystem_p.h 8861844 > src/kwindowsystem_p_x11.h 9baa6ae > src/kwindowsystem_x11.cpp 2016820 > src/netwm.h 2d812a7 > src/netwm.cpp 1daad1e > src/netwm_p.h a201cb6 > > Diff: https://git.reviewboard.kde.org/r/119267/diff/ > > > Testing > ------- > > Yes, works with the new activity switcher. > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
