----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/#review63888 -----------------------------------------------------------
Ship it! Looks reasonable to me. - Aleix Pol Gonzalez On Aug. 5, 2014, 9:09 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119588/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 9:09 p.m.) > > > Review request for Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > The original purpose of this was to set the QT_NO_DEBUG macro if the old > DebugFull configuration was used. We got rid of DebugFull (instead just > using Debug), so it is no longer relevant, and this hack never belonged > in ECMConfig.cmake anyway (it should have been in KDECompilerSettings). > > CHANGELOG: ECM now works when the required CMake version is set to > 3.0.0 or higher, and does not require Qt5Core to be available. > > BUG: 331849 > > > Diffs > ----- > > ECMConfig.cmake.in ea47abf0d8b025dd9e424b0aea26986d1f288279 > > Diff: https://git.reviewboard.kde.org/r/119588/diff/ > > > Testing > ------- > > kimageformats configures when the required CMake version is set to 3.0.0 in > (before, the configure step would fail). > > oxygen-fonts configures when /usr/lib/cmake/Qt5Core is removed (before, the > configure step would fail). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
