-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119564/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 7:07 a.m.)
Status
------
This change has been discarded.
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Bugs: 337472
http://bugs.kde.org/show_bug.cgi?id=337472
Repository: extra-cmake-modules
Description
-------
Upstream Qt commit e112c2e altered the way QExplicitlySharedDataPointer behaves
by default, such that it no longer uses a `static_cast` to cast compatible
pointers. A nontrivial amount of KDE code (I encountered the build error in
KService, although there are other users) depends on this functionality, so
this commit adds a define to the build system which re-enables the code in Qt.
Diffs
-----
kde-modules/KDECompilerSettings.cmake fdc930e
Diff: https://git.reviewboard.kde.org/r/119564/diff/
Testing
-------
I applied this patch, attempted to build KService, and the build succeeded,
rather than exhibiting the compile errors found in the log provided on the bug
report.
Thanks,
Axel Rasmussen
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
