----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119577/#review63677 -----------------------------------------------------------
Ship it! Translations might be broken due to https://bugreports.qt-project.org/browse/QTBUG-40444 , otherwise thanks for the fix! - Lukáš Tinkl On Srp. 2, 2014, 7:07 odp., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119577/ > ----------------------------------------------------------- > > (Updated Srp. 2, 2014, 7:07 odp.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Bugs: 337979 > https://bugs.kde.org/show_bug.cgi?id=337979 > > > Repository: kconfig > > > Description > ------- > > Allow translations to have context again. > > Switch to using QT_TRANSLATE_NOOP3 so that context information can be > given for actions, allowing the translators to do better translations. > > BUG: 337979 > FIXED-IN: 5.1.0 > > I don't know if it is worthwhile to get this in for 5.1.0, or wait for 5.2. > Would it help the translators to get it in now? If not, I'll get it in for > 5.2 (and update the FIXED-IN tag). > > Also, is there an easy way to test translations? It compiles, and the test > suite does run, but I don't have any translations so I don't know if it > actually works. Any pointers to documentation would be great. > > > Diffs > ----- > > src/gui/kstandardshortcut.cpp eb50888a263e9662bdac6c3e046d653577c003e4 > > Diff: https://git.reviewboard.kde.org/r/119577/diff/ > > > Testing > ------- > > Compiles, test suite passes. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
