----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510/#review63662 -----------------------------------------------------------
Ship it! Ship It! - David Faure On July 28, 2014, 2:28 p.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119510/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 2:28 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > This patch fixes QLocale usage in kbuildsycoca by not setting the default C > locale when creating the sycoca database (leftover from a KLocale port?). > Otherwise this results in menu entries being in English only (in effect > KDesktopFile, KService and other classes returning the original strings > instead of the uset-visible translated messages) > > > Diffs > ----- > > src/kbuildsycoca/kbuildsycoca.cpp 2f8405c > src/services/kservice.cpp c2b5ccf > > Diff: https://git.reviewboard.kde.org/r/119510/diff/ > > > Testing > ------- > > Current Plasma 5 workspace/desktop > > > File Attachments > ---------------- > > translated systemsettings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png > > > Thanks, > > Lukáš Tinkl > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
