> On Aug. 1, 2014, 1:16 p.m., David Edmundson wrote: > > probably needs the BUG n comments that the other two places have. Either > > that or wrap all the other code in an else {} rather than using a return.
added BUG comments - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119560/#review63624 ----------------------------------------------------------- On Aug. 1, 2014, 11:56 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119560/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 11:56 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kitemviews > > > Description > ------- > > updateGeometries() temporarly changes the value of the scrollbar policy. > make sure to have set it back when the function returns. > It avoids scrollbars always disabled, see > https://git.reviewboard.kde.org/r/119557/ > > > Diffs > ----- > > src/kcategorizedview.cpp 2d9296b > > Diff: https://git.reviewboard.kde.org/r/119560/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel