> On July 14, 2014, 1:40 p.m., David Edmundson wrote: > > autotests/coronatest.cpp, line 70 > > <https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line70> > > > > Why? > > > > I thought the overriding the plugin loader was so we don't need real > > plugins.
whithout any sycoca built in the test directory it hits an assert: since all applet constructors call KService::serviceByStorageId(serviceID) even if serviceID is empty in this case, it will anyways bomb if there is no valid sycoca db.. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/#review62294 ----------------------------------------------------------- On July 14, 2014, 12:30 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119270/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 12:30 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This is a simple autotest for loading a simple corona, checking that the > uiready signals are emitted, that adding and removing applets work, and the > immutability settings do work. > > The test is now passing and pretty basic, if someone can think about any new > things to test, please add in the test ;) > > > Diffs > ----- > > autotests/CMakeLists.txt 060132d > autotests/coronatest.h PRE-CREATION > autotests/coronatest.cpp PRE-CREATION > autotests/coronatestresources.qrc PRE-CREATION > autotests/plasma-test-appletsrc PRE-CREATION > src/plasma/corona.cpp e18f081 > src/plasma/private/containment_p.cpp f8b4578 > > Diff: https://git.reviewboard.kde.org/r/119270/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
