> On Iulie 12, 2014, 6:54 p.m., David Faure wrote: > > Doesn't qplatformdefs.h define this already? > > David Faure wrote: > Ah not exactly, but you can use & QT_STAT_DIR and & QT_STAT_REG.
Yeah, that was my other option, I'm going to update the diff. - Cristian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 ----------------------------------------------------------- On Iulie 12, 2014, 2:20 p.m., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119248/ > ----------------------------------------------------------- > > (Updated Iulie 12, 2014, 2:20 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kio > > > Description > ------- > > IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The > macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the > file provided Visual Studio so I chose this approach which is also used in Qt. > > Here is the compiler output: > > kshorturifilter.cpp > q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: > 'S_ISDIR': identifier not found > q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: > 'S_ISREG': identifier not found > > > Diffs > ----- > > src/urifilters/shorturi/kshorturifilter.cpp 8341829 > > Diff: https://git.reviewboard.kde.org/r/119248/diff/ > > > Testing > ------- > > Build with msvc2013 on Windows and gcc-4.8.3 on Linux. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
