----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/#review61345 -----------------------------------------------------------
This review has been submitted with commit 054d849879647fd4cf90c4f622877d3a11720bb2 by David Faure to branch master. - Commit Hook On June 29, 2014, 1:55 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118985/ > ----------------------------------------------------------- > > (Updated June 29, 2014, 1:55 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > KSharedConfig: move mainConfig and wasTestEnabled to the thread storage. > > This enables the mainConfig optimization in all threads, > and ensures the user warning only happens in the main thread. > > The test-mode-enabled logic is only really useful in the main thread, > but it's simpler to just do it in all threads. > > REVIEW: 118985 > > > Diffs > ----- > > autotests/kconfigtest.cpp a8482b7099df5921909830082d758dc3095e3241 > src/core/ksharedconfig.cpp b7d155d5893502921d35d7dd971188b6a93a0620 > > Diff: https://git.reviewboard.kde.org/r/118985/diff/ > > > Testing > ------- > > no regression in "make test" in kconfig; still debugging races in helgrind > threadtest (in kio). > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
