----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60569 -----------------------------------------------------------
kcms/keyboard/bindings.cpp <https://git.reviewboard.kde.org/r/118366/#comment42272> Use qCDebug? Using qDebug alone only means torrents of debug output that nobody will ever read. kcms/keyboard/flags.cpp <https://git.reviewboard.kde.org/r/118366/#comment42273> remove? kcms/keyboard/flags.cpp <https://git.reviewboard.kde.org/r/118366/#comment42274> wtf happened here? xD kcms/keyboard/kcmmisc.cpp <https://git.reviewboard.kde.org/r/118366/#comment42275> please, don't add commented code. kcms/keyboard/kcmmisc.cpp <https://git.reviewboard.kde.org/r/118366/#comment42276> I wouldn't do coding style changes while coding. - Aleix Pol Gonzalez On June 19, 2014, 6:48 p.m., shivam makkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 6:48 p.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > ------- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > ----- > > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp 6d25443 > kcms/keyboard/flags.cpp 3fb98e5 > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp d14ac2e > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp 49f059c > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp e357c6a > kcms/keyboard/x11_helper.h 719b13f > kcms/keyboard/x11_helper.cpp 0e2806e > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b245e91 > kcms/keyboard/xinput_helper.cpp 980338e > > Diff: https://git.reviewboard.kde.org/r/118366/diff/ > > > Testing > ------- > > > Thanks, > > shivam makkar > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
