----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60282 -----------------------------------------------------------
Ship it! Looks fine to me. - Kevin Ottens On June 14, 2014, 9:20 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118739/ > ----------------------------------------------------------- > > (Updated June 14, 2014, 9:20 a.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Make KSharedConfig thread-safe > > ... by having a different list of shareable objects per thread. > > > Diffs > ----- > > src/core/ksharedconfig.cpp f4b4c766fe19fac92a0651ecc55a89ec3b7636b0 > > Diff: https://git.reviewboard.kde.org/r/118739/diff/ > > > Testing > ------- > > helgrind kiocore-threadtest (not committed yet) > > no races detected in KSharedConfig anymore. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel