----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review59855 -----------------------------------------------------------
autotests/CMakeLists.txt <https://git.reviewboard.kde.org/r/118680/#comment41688> Why did you need to create a separate call to ecm_add_test? If it's for the target_include_directories, you can still do it to an ecm_add_tests created target. - Aleix Pol Gonzalez On June 11, 2014, 11:04 p.m., Thomas Braxton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118680/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 11:04 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Some tests are testing underlying components, these should be tested before > testing the components that depend on them. > > > Diffs > ----- > > autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 > > Diff: https://git.reviewboard.kde.org/r/118680/diff/ > > > Testing > ------- > > All tests still pass > > > Thanks, > > Thomas Braxton > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
