----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ -----------------------------------------------------------
(Updated June 6, 2014, 1:43 p.m.) Review request for KDE Frameworks and John Layt. Changes ------- ensure KConfigTest::testMerge() doesn't fail Repository: kconfig Description ------- Fix locale-aware reading in KDesktopFile The underlying KConfig used QLocale::name() for getting the locale aware part. But this returns "de_DE" while the desktop files store "de". In addition it constructs a QLocale object instead of using the system locale. This has the advantage that the usage of QLocale::setDafault() gets honored by KConfig. Diffs (updated) ----- autotests/kconfigtest.cpp 2b6de0d7d63df6aee69210aa09418628f0b8110a autotests/kdesktopfiletest.h d57351fd6edcefd6a0efd9126e454546cfc63b55 autotests/kdesktopfiletest.cpp 494a43c0fb5808a261b9beb56cdc4afd8580ab21 src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a Diff: https://git.reviewboard.kde.org/r/118564/diff/ Testing ------- added unit test failed before. I'm not 100 % sure whether using bcp47Name is correct. Thanks, Martin Gräßlin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
