----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/ -----------------------------------------------------------
(Updated June 4, 2014, 11:56 p.m.) Review request for KDE Frameworks and Matthew Dawson. Changes ------- New version, taking into account all comments. I'd appreciate it if someone can have a quick look over the comment to verify it makes sense. Summary (updated) ----------------- Properly mark ServiceBrowser::isRunning as deprecated. Repository: kdnssd Description (updated) ------- Properly mark ServiceBrowser::isRunning as deprecated. Fix the @deprecated notation to be correct. Also, make the function a simple inline function that always returns false. This should cause minimal breakage while avoiding overhead from the function. Diffs (updated) ----- src/mdnsd-servicetypebrowser.cpp d16dd1fa1c692cd20e21f1a7d5471ac7956469b3 src/dummy-servicetypebrowser.cpp 39a4b6b660bb47b68b5721535994487dbe2abbf6 src/avahi-servicetypebrowser.cpp b3c14f84367d5093a6cee5ef3f684edc201a3f96 src/servicetypebrowser.h 3cd10e36bf089e088e8a48bb0cf73daa4fb859c5 Diff: https://git.reviewboard.kde.org/r/118490/diff/ Testing ------- Code still compiles. Thanks, Matthew Dawson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
