-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118332/#review58506
-----------------------------------------------------------

Ship it!


Ship It!

- Matthew Dawson


On May 26, 2014, 2:38 p.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118332/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 2:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> According to http://qt-project.org/doc/qt-5/qvariant.html#type the
> return value of QVariant::type() should be interpreted as a
> QMetaType::Type.
> This also silences the compile-time warnings about 38 not being a member
> of QVariant::Type.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b 
> 
> Diff: https://git.reviewboard.kde.org/r/118332/diff/
> 
> 
> Testing
> -------
> 
> All tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to