----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58383 -----------------------------------------------------------
src/ktitlewidget.cpp <https://git.reviewboard.kde.org/r/118289/#comment40609> Can you at least make this a bit less "magical"? Right now it's just "size * 1.3".. Why 1.3? What is the basis behind it besides that it looks good in your opinion? Please do this in some generic KDE wide define or perhaps even an environment variable. For example "KDE_INCREASE_FONT_FACTOR = 1.3" that way it is clear what you mean and somewhat more discoverable and can be tweaked by users/distros if they feel the need. Note: imho you can drop the "Font settings" title and all the titles in every KTile* since it doesn't seem to add much info. You select the "Fonts" in the left menu anyway so it is common sense that you get "<selected name> settings" in the right pane.. But that's just my opinion for that :) - Mark Gaiser On May 24, 2014, 12:10 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118289/ > ----------------------------------------------------------- > > (Updated May 24, 2014, 12:10 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > Change titlewidget from bold to increased font size > > This patch removes the bold weight from KTitleWidget and makes the text > a bit bigger, improving focus. This is more in line with common > expectations of a title, and it's more in line with Plasma 5's > typography. > > > Diffs > ----- > > src/ktitlewidget.cpp b1f3ca714670a6eaa49048d67221d90d11480cec > > Diff: https://git.reviewboard.kde.org/r/118289/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > titlewidget in systemsettings (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png > titlewidget in systemsettings (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png > titlewidget in kate (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png > titlewidget in kate (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
