----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58274 -----------------------------------------------------------
autotests/kwindowsystemx11test.cpp <https://git.reviewboard.kde.org/r/118252/#comment40541> found no spec, but from tronche: "Window managers *may* elect to receive this message and if the window is in its normal state, *may* treat it as a request to change the window's state from normal to iconic." Also WMs can of course place windows minimized (first test fails) or ignore un/minimize requests altogether (virtual desktop implementation etc.) Also this will likely fail if there's just no WM during the test... src/kwindowsystem_x11.cpp <https://git.reviewboard.kde.org/r/118252/#comment40538> Do we have a strategy on this? - Thomas Lübking On May 22, 2014, 6:53 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118252/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 6:53 a.m.) > > > Review request for KDE Frameworks, kwin and Eike Hein. > > > Repository: kwindowsystem > > > Description > ------- > > Port KWindowSystem::minimizeWindow and unminizeWindow to XCB > > Unit test added to verify that the functionality works correctly. > > Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the > create_atoms() function is not yet ported to xcb. > > > Diffs > ----- > > autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 > src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 > > Diff: https://git.reviewboard.kde.org/r/118252/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
