----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117989/#review57261 -----------------------------------------------------------
Ship it! Alright, makes sense. A test for the behaviour can be made later. - Matthew Dawson On May 4, 2014, 2:32 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117989/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 2:32 p.m.) > > > Review request for KDE Frameworks, Elias Probst and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Store app config file in ~/.config/<domain>/<app>rc > > Only KSharedConfig::openConfig() and KConfig default constructor are affected. > > KConfig("kdeglobals"), for instance, points to ~/.config so that it can be > shared. > > > Diffs > ----- > > src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a > > Diff: https://git.reviewboard.kde.org/r/117989/diff/ > > > Testing > ------- > > http://www.davidfaure.fr/2014/domainname_test.diff passes > > I didn't try booting into a plasma workspace desktop though. > > This change breaks any code that 1) sets a domainname, and 2) assume the > config file will be directly under [Generic]ConfigLocation, e.g. to move it > or migrate to it or something. Quite rare though, and it's still time :) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
