----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ -----------------------------------------------------------
Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description ------- Deprecate ecm_dbus_add_activation_service() This is a bit of a pointless macro: it can be replaced with two lines for each input file (and it is usually only called with a single input file), and it is much clearer what those two lines do. Diffs ----- modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 Diff: https://git.reviewboard.kde.org/r/117581/diff/ Testing ------- Built documentation; built and installed KWallet (one of the two users of this macro). Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel