----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117313/#review55014 -----------------------------------------------------------
Ship it! Ship It! - David Faure On April 1, 2014, 9:49 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117313/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 9:49 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Improve ThumbCreator apidox > > Also add a couple of KF6 TODOs > > Deprecate ThumbCreatorV2 > > This only existed to add virtual methods to ThumbCreator while keeping > binary compatibility. These methods have now been moved into > ThumbCreator. > > > Diffs > ----- > > src/widgets/thumbcreator.h 063ba105cf1dd55f8bfee5ee14e3af8a51276eb7 > src/widgets/thumbcreator.cpp 7d3c52bb0f68ce43a11f5b1e732942016be59bf0 > > Diff: https://git.reviewboard.kde.org/r/117313/diff/ > > > Testing > ------- > > Builds and installs, as does kde-runtime (where there is code that implements > and makes use of these interfaces). > > Apidox builds and looks fine. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
