----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kxmlgui Description ------- Use KIconDialog instead of running kdialog to choose icons KIconDialog is no longer in KIO, but in KIconThemes, and so we can make use of it. Diffs ----- src/kedittoolbar_p.h 417a53f4c1332ea0d94c5bac99bbcf486eaccfa8 src/kedittoolbar.cpp 97a7c35ac79fb9f9ab69a497f4b783acf43b632a Diff: https://git.reviewboard.kde.org/r/117272/diff/ Testing ------- Builds and tests pass. kwindowtest allows an icon to be selected when editing the toolbars, although that icon doesn't appear (probably because QIcon::fromTheme() isn't working properly for me). Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
