----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review53889 -----------------------------------------------------------
src/kjsembed/CMakeLists.txt <https://git.reviewboard.kde.org/r/117012/#comment37772> (Most of) the other frameworks do the opposite: install the regular headers in INCLUDE_INSTALL_DIR/<framework name>. What about changing the line above to have everything installed in INCLUDE_INSTALL_DIR/KJsEmbed instead? - Christophe Giboudeaux On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117012/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 1:33 a.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kjsembed > > > Description > ------- > > Currently kjsembed CMake file tries to install both > ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and > ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not > allowed in a case-insensitive filesystem, causing the install step to fail on > Windows. > > > Diffs > ----- > > src/kjsembed/CMakeLists.txt e0ab74c > > Diff: https://git.reviewboard.kde.org/r/117012/diff/ > > > Testing > ------- > > Tested using MSVC 2013 > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
