----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116914/#review53603 -----------------------------------------------------------
Ship it! bye old code - David Faure On March 20, 2014, 6:31 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116914/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 6:31 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kde4support > > > Description > ------- > > Remove KLibLoader::createInstance methods > > These have been deprecated since 4.0, and use the long-deprecated > KLibrary::factory() method. LXR says there is a single user: jovie (in > kdeaccessibility). > > > Depends on 116913, because KParts::ComponentFactory methods make use of > KLibLoader error codes. > > > Diffs > ----- > > autotests/klibloadertest.h 7307fea0ef69b302eb64aa121e4af54e034c24ab > autotests/klibloadertest.cpp a6aebd278ea8e7121ccbb91422d08964d8dcf07a > src/kdecore/klibloader.h 07d0c1c4bd4747b394745d9b7af0765874c4d6e3 > src/kdecore/klibloader.cpp b9d0625025445f7c200608be06433bd19ec6ead0 > > Diff: https://git.reviewboard.kde.org/r/116914/diff/ > > > Testing > ------- > > Builds, compiles, tests pass. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
