----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ -----------------------------------------------------------
(Updated March 18, 2014, 10:25 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description ------- Clean up KCompletionBox -canceled() -> cancelled (private method) -Deprecate sizeAndPosition() --> resizeAndReposition() -Remove old comments and commented-out code -Move some slots to be normal methods, since they don't seem to be able to work as slots. Diffs ----- src/kcompletionbox.h 09b7527 src/kcompletionbox.cpp 92e87b3 Diff: https://git.reviewboard.kde.org/r/116747/diff/ Testing ------- It builds and tests pass. Thanks, David Gil Oliva
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
