----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116653/ -----------------------------------------------------------
Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description ------- Factor out common code for component-based find modules This comes with improvements for FindWayland and FindXCB: - <module>_VERSION instead of <module>_VERSION_STRING - set <module>_LIBRARIES to contain targets, so that <module>_INCLUDE_DIRS and <module>_DEFINITIONS are unnecessary - do pkg-config calls per-component - handle inter-component dependencies - improve documentation (in CMake 3.0 style) - improve license texts (following CMake's style) In FindWayland: - extract the version from wayland-version.h if necessary Diffs ----- find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4 find-modules/FindXCB.cmake eb3075885bc408fc4c213516a387dfcd0e75cb8b modules/ECMFindModuleHelpers.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116653/diff/ Testing ------- Tested various configurations with a test CMakeLists.txt file, including with various include files missing. Configured and built kwindowsystem and kde-workspace. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
