----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116080/#review51599 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Feb. 26, 2014, 3:07 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116080/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 3:07 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > find_dependency: Update to match CMake's version > > Specifically, we namespace the variables to avoid conflicts, and make > the version argument optional. > > > Diffs > ----- > > modules/ECMPackageConfigHelpers.cmake > ee6bfd6f7e79a9f842ad6d34931a9273c2ee3c4f > > Diff: https://git.reviewboard.kde.org/r/116080/diff/ > > > Testing > ------- > > kdesrc-build with clean build and install dirs successful, using CMake 2.8.12 > (and so using this version of find_dependency, rather than the one shipped > with CMake 3.0). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
