----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116064/#review51414 -----------------------------------------------------------
Ship it! Nice! Thanks. Spotted two things that are now outdated, but go ahead either way. src/kdecore/kurl.h <https://git.reviewboard.kde.org/r/116064/#comment36207> Well, not anymore ;) Now it would be rather QUrl::fromUserInput(). src/kdecore/kurl.h <https://git.reviewboard.kde.org/r/116064/#comment36208> (or rather the QUrl equivalent of that) - David Faure On March 1, 2014, 10:32 a.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116064/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 10:32 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kde4support > > > Description > ------- > > @deprecated docs for KUrl methods that duplicate QUrl methods > > Some KUrl methods just forward to their QUrl counterparts (or do > .isEmpty() on a QUrl method result); replace the apidox for these with a > note saying what QUrl method should be used instead. > > > Diffs > ----- > > src/kdecore/kurl.h 4ac893382c76def83f8e6e12698931df243085f9 > > Diff: https://git.reviewboard.kde.org/r/116064/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
