----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review51008 -----------------------------------------------------------
Ship it! The QByteArray clearly has the same lifetime as the argv array itself, so should be fine. - Alex Merry On Feb. 26, 2014, 5 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116087/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 5 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcrash > > > Description > ------- > > remove usage of strlcpy > > That copy was actually unnecessary, incrementing the refcount on > QByteArray and then calling constData() is enough > > > Diffs > ----- > > src/kcrash.cpp 6c41022206130f186d52ddbb77afd58c429f368f > src/strlcpy-fake.c 9b2dc68c466908d11370ba0c4bbe8d315962da5d > src/CMakeLists.txt d19b97f98e057d5537cf0eb6a8e1997d2a24cb1e > src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 > > Diff: https://git.reviewboard.kde.org/r/116087/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
