----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: karchive Description ------- Four commits (in git log order): Simplify autotests CMakeLists.txt Separate out tests of deprecated functions to their own file This allows us to disable deprecation warnings just for that file. Inline deprecated methods This both documents how to replace them in the headers and ensures that enabling or disabling deprecated functions does not affect the ABI. Use KARCHIVE_NO_DEPRECATED instead of KDE_NO_DEPRECATED Diffs ----- autotests/CMakeLists.txt 1da853fe49ec6fca40ccf417db788340124b41e5 autotests/deprecatedtest.cpp PRE-CREATION autotests/karchivetest.cpp 6d6b5848ce9add84736968dd13f529711f895493 src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd src/karchive.cpp a25b85e41618d1f7ae62e7e41966afe1a8aaef8e src/kfilterdev.h 4a35879a15992d19378c7e9baa9b206e187713fd src/kfilterdev.cpp 60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3 Diff: https://git.reviewboard.kde.org/r/116012/diff/ Testing ------- Builds, tests pass. No deprecation warnings (before there were two in the tests). Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
